Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/98#discussion_r57676029
--- Diff:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
---
@@ -112,11 +126,16 @@ public static WebDriver getDriverForPage(String url,
Configuration conf) {
}
LOG.debug("Selenium {} WebDriver selected.", driverType);
+ driver.manage().timeouts().pageLoadTimeout(pageLoadWait,
TimeUnit.SECONDS);
driver.get(url);
- new WebDriverWait(driver, pageLoadWait);
} catch (Exception e) {
- throw new RuntimeException(e);
- }
+ if(e instanceof TimeoutException) {
--- End diff --
@karanjeets please always use the Eclipse code format
https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
