[
https://issues.apache.org/jira/browse/NUTCH-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215508#comment-15215508
]
ASF GitHub Bot commented on NUTCH-2241:
---------------------------------------
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/98#discussion_r57676028
--- Diff:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
---
@@ -112,11 +126,16 @@ public static WebDriver getDriverForPage(String url,
Configuration conf) {
}
LOG.debug("Selenium {} WebDriver selected.", driverType);
+ driver.manage().timeouts().pageLoadTimeout(pageLoadWait,
TimeUnit.SECONDS);
driver.get(url);
- new WebDriverWait(driver, pageLoadWait);
} catch (Exception e) {
- throw new RuntimeException(e);
- }
+ if(e instanceof TimeoutException) {
--- End diff --
@karanjeets please always use the Eclipse code format
https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml
> Unstable Selenium plugin in Nutch. Fixed bugs and enhanced configuration
> ------------------------------------------------------------------------
>
> Key: NUTCH-2241
> URL: https://issues.apache.org/jira/browse/NUTCH-2241
> Project: Nutch
> Issue Type: Bug
> Components: plugin, protocol
> Affects Versions: 1.12
> Environment: Fixed for Firefox browser with version 25 and above.
> Reporter: Karanjeet Singh
> Assignee: Chris A. Mattmann
> Labels: firefox, interactiveselenium, lib-selenium, memex,
> nutch, nutch-default.xml, plugin, protocol, selenium
> Fix For: 1.12
>
>
> Issues:
> (a) Firefox browser doesn't close gracefully.
> (b) The property libselenium.page.load.delay is not working. No matter how
> much delay you give, the driver is not waiting for the page to load.
> (c) There is no timeout configured for the firefox binary.
> (d) A lot of selenium configuration is hard-coded which can be exposed
> through nutch-default.xml or nutch-site.xml
> All these issues are part of "lib-selenium" plugin which is being used by two
> other protocols "protocol-selenium" and "protocol-interactiveselenium".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
