[ 
https://issues.apache.org/jira/browse/NUTCH-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292529#comment-15292529
 ] 

ASF GitHub Bot commented on NUTCH-2264:
---------------------------------------

Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/115#discussion_r63980262
  
    --- Diff: build.xml ---
    @@ -1035,4 +1039,11 @@
           </classpath>
         </eclipse>
       </target>
    +
    +  <target name="check-forbidden-apis" depends="compile">
    +    <fa:forbiddenapis internalRuntimeForbidden="true" 
classpathref="classpath" dir="${build.dir}">
    +      <bundledsignatures name="jdk-unsafe-${javac.version}"/>
    --- End diff --
    
    yes I think we should make full use of the plugin e.g. add more checks from 
the available options. If you wish to split these in to separate items and 
merge them gradually then I would be happy to merge. Please say what you want 
to do.


> Check Forbidden API's at Build
> ------------------------------
>
>                 Key: NUTCH-2264
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2264
>             Project: Nutch
>          Issue Type: Task
>    Affects Versions: 2.3.1
>            Reporter: Furkan KAMACI
>            Priority: Minor
>
> We should avoid [forbidden 
> calls|https://github.com/policeman-tools/forbidden-apis/wiki]  and check in 
> the ant build for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to