[
https://issues.apache.org/jira/browse/NUTCH-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429457#comment-15429457
]
ASF GitHub Bot commented on NUTCH-2302:
---------------------------------------
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/143#discussion_r75582137
--- Diff: src/java/org/apache/nutch/api/impl/RAMConfManager.java ---
@@ -42,6 +42,10 @@ public RAMConfManager() {
configurations.put(ConfigResource.DEFAULT,
NutchConfiguration.create());
}
+ public RAMConfManager(String confId, Configuration configuration) {
--- End diff --
Javadoc on all public methods please. Can you update all of the code you've
proposed so far with Javadoc.
> RAMConfManager Could Be Constructed With Custom Configuration
> --------------------------------------------------------------
>
> Key: NUTCH-2302
> URL: https://issues.apache.org/jira/browse/NUTCH-2302
> Project: Nutch
> Issue Type: Improvement
> Components: REST_api, web gui
> Reporter: Furkan KAMACI
> Assignee: Furkan KAMACI
> Fix For: 2.4
>
>
> RAMConfManager is intented to hold different configurations which can be
> accessible via a configuration id. However, it forces you to use a default
> configuration with a default id when you construct it. When RAMConfManager is
> used by any other classes they cannot set a custom configuration and it leads
> problem. i.e. test resources cannot be used when you test NutchServer due to
> it uses default configuration which is forced by RAMConfManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
