[
https://issues.apache.org/jira/browse/NUTCH-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079393#comment-16079393
]
ASF GitHub Bot commented on NUTCH-2375:
---------------------------------------
lewismc commented on a change in pull request #188: NUTCH-2375 Upgrade the code
base from org.apache.hadoop.mapred to org.apache.hadoop.mapreduce
URL: https://github.com/apache/nutch/pull/188#discussion_r126293237
##########
File path: src/java/org/apache/nutch/segment/SegmentMerger.java
##########
@@ -384,40 +385,43 @@ public void setConf(Configuration conf) {
public void close() throws IOException {
}
- public void configure(JobConf conf) {
+ public void configure(Job job) {
+ Configuration conf = job.getConfiguration();
setConf(conf);
if (sliceSize > 0) {
- sliceSize = sliceSize / conf.getNumReduceTasks();
+ sliceSize = sliceSize /
Integer.parseInt(conf.get("mapreduce.map.tasks"));
Review comment:
This does not look correct at all... we should be attempting to obtain a
slice size value by diving an integer whose value is greater than zero by the
configured number of Reduce tasks... not by the configured number of Map tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade the code base from org.apache.hadoop.mapred to
> org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: NUTCH-2375
> URL: https://issues.apache.org/jira/browse/NUTCH-2375
> Project: Nutch
> Issue Type: Improvement
> Components: deployment
> Reporter: Omkar Reddy
>
> Nutch is still using the deprecated org.apache.hadoop.mapred dependency which
> has been deprecated. It need to be updated to org.apache.hadoop.mapreduce
> dependency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
