[
https://issues.apache.org/jira/browse/NUTCH-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193269#comment-16193269
]
ASF GitHub Bot commented on NUTCH-2429:
---------------------------------------
lewismc commented on a change in pull request #222: NUTCH-2429 Fix Plugin
System to allow protocol plugins to bundle their URLStreamHandlers
URL: https://github.com/apache/nutch/pull/222#discussion_r143004560
##########
File path: src/plugin/protocol-foo/src/java/my/foo/Foo.java
##########
@@ -0,0 +1,126 @@
+package my.foo;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.Text;
+import org.apache.nutch.crawl.CrawlDatum;
+import org.apache.nutch.metadata.Metadata;
+import org.apache.nutch.net.protocols.HttpDateFormat;
+import org.apache.nutch.plugin.URLStreamHandlerFactory;
+import org.apache.nutch.protocol.Content;
+import org.apache.nutch.protocol.Protocol;
+import org.apache.nutch.protocol.ProtocolOutput;
+import org.apache.nutch.protocol.ProtocolStatus;
+import org.apache.nutch.protocol.RobotRulesParser;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import crawlercommons.robots.BaseRobotRules;
+
+public class Foo implements Protocol {
+ protected static final Logger LOG = LoggerFactory.getLogger(Foo.class);
+
+ private Configuration conf;
+
+ @Override
+ public Configuration getConf() {
+ LOG.debug("getConf()");
+ return conf;
+ }
+
+ @Override
+ public void setConf(Configuration conf) {
+ LOG.debug("setConf(...)");
Review comment:
Please remove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers
> -----------------------------------------------------------------------------
>
> Key: NUTCH-2429
> URL: https://issues.apache.org/jira/browse/NUTCH-2429
> Project: Nutch
> Issue Type: Improvement
> Components: commoncrawl
> Affects Versions: 1.14
> Environment: Tested on both Nutch 1.13 and 1.14 in Ubuntu Linux with
> OpenJDK 1.8.
> Reporter: Hiran Chaudhuri
> Fix For: 1.14
>
>
> While trying to use the protocol-smb plugin (which is not part of the Nutch
> distribution) I realized there are four steps to successfully make use of a
> protocol plugin:
> 1 - put the artifact into the plugins directory
> 2 - modify Nutch configuration files to allow smb:// urls plus include the
> plugin to the loaded list
> 3 - extract jcifs.jar and place it on the system classpath
> 4 - run nutch with the correct system property
> While steps 1 and 2 seem obvious, 3 and 4 require knowledge of plugin
> internals which does not feel right for nutch and plugin users. Even more,
> the jcifs.jar would exist twice on the classpath and could even cause further
> problems during runtime.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
