Hello, I am doing some reading and I believe I have identified a block of code who's logic is flawed. I'm on master.
Go to ParseOutputFormat, I am comparing block of code, block one is line 362-378 and then block two is 379 - 394. There are 4 fixemes in these two blocks also, so while considering what I have to say it might be worth reading those also. Now block one is trying to ignore external links, it seems ok. I am eyeballing this like my last fix, doing the logic in my head. My very first question is why we are doing boolean comparison for blocks with two different intents with the same variable. Explicitly stated, shouldnt line 380 use a boolean of "ignoreInternalLinks" instead of external? Aso, there is no exemption filter checking under block two like there is in block one. I know this is abstact, I wish I could just post the code somehow with snippets but thanks for taking the time to look as I'm almost dead certain this is flawed logic again
