[
https://issues.apache.org/jira/browse/NUTCH-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296168#comment-16296168
]
ASF GitHub Bot commented on NUTCH-2450:
---------------------------------------
kpm1985 commented on issue #235: Fix for NUTCH-2450 by Kenneth McFarland
URL: https://github.com/apache/nutch/pull/235#issuecomment-352634339
I closed the issue. The code is still labeled "FIXME", I don't want to mess
up closing issues @lewismc and since Eclipse has been being such a frustration
issue I am just going to take a break from the time + frustration issues and
come back.
I hope that is ok, I have taken notes and will come back with a preemptive
strike next time. I'm just not good with pressure right now. Thank you for
giving me the direction, the next time I PR it will have more thought because
of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove FixMe in ParseOutputFormat
> ---------------------------------
>
> Key: NUTCH-2450
> URL: https://issues.apache.org/jira/browse/NUTCH-2450
> Project: Nutch
> Issue Type: Bug
> Environment: master branch
> Reporter: Kenneth McFarland
> Assignee: Kenneth McFarland
> Priority: Minor
>
> ParseOutputFormat contains a few FixMe's that I've looked at. If a valid url
> is created, it will always return valid results. There is a spot in the code
> where the try catch is already done, so the predicate is satisfied and there
> is no need to keep checking it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
