[
https://issues.apache.org/jira/browse/NUTCH-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307230#comment-16307230
]
ASF GitHub Bot commented on NUTCH-2460:
---------------------------------------
hussein-alahmad commented on a change in pull request #245: fix for NUTCH-2460
contributed by Hussein Alahmad
URL: https://github.com/apache/nutch/pull/245#discussion_r159143021
##########
File path:
src/plugin/lib-selenium/src/java/org/apache/nutch/protocol/selenium/HttpWebClient.java
##########
@@ -166,7 +175,7 @@ public static String getHTMLContent(WebDriver driver,
Configuration conf) {
public static void cleanUpDriver(WebDriver driver) {
if (driver != null) {
try {
- driver.close();
+// driver.close();
Review comment:
there is a driver.quit() statement after it , I was getting an error about
trying to close a non existing connection , after searching about it , turned
out that driver.quit() alone without the driver.close() do the work
as mentioned [here](https://github.com/mozilla/geckodriver/issues/966)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> use the headless option of firefox and chrome in protocol-selenium
> ------------------------------------------------------------------
>
> Key: NUTCH-2460
> URL: https://issues.apache.org/jira/browse/NUTCH-2460
> Project: Nutch
> Issue Type: Improvement
> Components: plugin, protocol
> Reporter: hussein Al_Ahmad
> Priority: Minor
>
> the --headless option is added to firefox in version 55 or later , and in
> chrome in version 59 or later ...
> this is much better than relying on xvfb and its associates .
> we can add it as a property in the config file .
> I'm trying it on my local machine , and will create a pull request when I
> finish testing it .
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
