[ 
https://issues.apache.org/jira/browse/NUTCH-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387539#comment-16387539
 ] 

ASF GitHub Bot commented on NUTCH-2522:
---------------------------------------

sebastian-nagel commented on a change in pull request #290: NUTCH-2522
URL: https://github.com/apache/nutch/pull/290#discussion_r172459390
 
 

 ##########
 File path: conf/db-ignore-external-exemptions-bidirectional.txt
 ##########
 @@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+# Exemption rules to db.ignore.external.links
+
+
+# Format :
+#--------
+# The format is same same as `regex-urlfilter.txt`.
+# Each non-comment, non-blank line contains a regular expression
+# prefixed by '+' or '-'.  The first matching pattern in the file
+# determines whether a URL is exempted or ignored.  If no pattern
+# matches, the URL is ignored.
+
+
+
+# Example 1:
+#----------
+# To exempt urls ending with image extensions, uncomment the below line
+-(www.)
 
 Review comment:
   Why the rule starts with `+-`? The dot is not escaped, would also apply to 
`wwwfinder` catching `wwwf`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


>  Bidirectional URL exemption filter
> -----------------------------------
>
>                 Key: NUTCH-2522
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2522
>             Project: Nutch
>          Issue Type: Improvement
>          Components: plugin
>            Reporter: Semyon Semyonov
>            Priority: Minor
>
> The current Nutch Url Exemption plugin exempts based on toUrl only, the new 
> plugin uses both fromUrl and toUrl and after the regex transformation, 
> exempts based on condition regex(fromUrl) == regex(toUrl).
> This approach allows us to perform more complex url exemption filter checks, 
> such as allow links:
> http://[www.website.com/|http://www.website.com/]home -> 
> http://[website.com/a|http://www.website.com/]bout ( with/without www).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to