[ 
https://issues.apache.org/jira/browse/NUTCH-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416245#comment-16416245
 ] 

ASF GitHub Bot commented on NUTCH-2518:
---------------------------------------

Omkar20895 opened a new pull request #307: NUTCH-2518 Cleaning up the file 
system after a job failure.
URL: https://github.com/apache/nutch/pull/307
 
 
   - Added a new method cleanupAfterFailure which was already existing in 
Injector.
   - I have added this only in one of the 25 instances of 
job.waitForCompletion(true), please go ahead and review it and I will 
incorporate the review comments in the upcoming commits/changes.
   
   Confusion: 
   - When a job failure happens do we need to do System.exit(non-zero status) 
or throw a runtime exception with a custom message specific to each class? I 
went ahead with the later one. Please suggest otherwise with reason. 
   
   Thanks.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Must check return value of job.waitForCompletion()
> --------------------------------------------------
>
>                 Key: NUTCH-2518
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2518
>             Project: Nutch
>          Issue Type: Bug
>          Components: crawldb, fetcher, generator, hostdb, linkdb
>    Affects Versions: 1.15
>            Reporter: Sebastian Nagel
>            Assignee: Kenneth McFarland
>            Priority: Blocker
>             Fix For: 1.15
>
>
> The return value of job.waitForCompletion() of the new MapReduce API 
> (NUTCH-2375) must always be checked. If it's not true, the job has been 
> failed or killed. Accordingly, the program
> - should not proceed with further jobs/steps
> - must clean-up temporary data, unlock CrawlDB, etc.
> - exit with non-zero exit value, so that scripts running the crawl workflow 
> can handle the failure
> Cf. NUTCH-2076, NUTCH-2442, [NUTCH-2375 PR 
> #221|https://github.com/apache/nutch/pull/221#issuecomment-332941883].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to