[ 
https://issues.apache.org/jira/browse/NUTCH-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527924#comment-16527924
 ] 

ASF GitHub Bot commented on NUTCH-2602:
---------------------------------------

r0ann3l opened a new pull request #356: fix for NUTCH-2602: Index writers 
description
URL: https://github.com/apache/nutch/pull/356
 
 
   When the index writers description is shown, it appears in the form 
**\<key>:\<value>** where **\<key>** is the parameter's name used on 
index-writers.xml file and **\<value>** is the value that the parameter has. To 
acomplish this, the `describe()` method should be called after the `open()` 
method. For this reason I moved the line `LOG.info(writers.describe());` on 
`IndexingJob.java:124` to `IndexerOutputFormat.java:45`. This change is 
suitable because now the `IndexWriters.get(conf)` method isn't invoked twice.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Configuration values in the description of index writers
> --------------------------------------------------------
>
>                 Key: NUTCH-2602
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2602
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, plugin
>    Affects Versions: 1.15
>            Reporter: Roannel Fernández Hernández
>            Priority: Minor
>             Fix For: 1.16
>
>
> Since [GitHub Pull Request #218|https://github.com/apache/nutch/pull/218] 
> when you have 2+ different configuration of the same index writers (the same 
> implementation class), the index command print the same description several 
> times. I propose the {{describe()}} method show the values of its own 
> configuration and not a generic one.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to