[ 
https://issues.apache.org/jira/browse/NUTCH-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576280#comment-16576280
 ] 

ASF GitHub Bot commented on NUTCH-2633:
---------------------------------------

sebastian-nagel commented on a change in pull request #374: NUTCH-2633 Fix 
deprecation warnings when building Nutch master branch…
URL: https://github.com/apache/nutch/pull/374#discussion_r209256339
 
 

 ##########
 File path: 
src/plugin/protocol-httpclient/src/java/org/apache/nutch/protocol/httpclient/Http.java
 ##########
 @@ -130,7 +130,7 @@ public Http() {
    */
   public void setConf(Configuration conf) {
     super.setConf(conf);
-    this.conf = conf;
+    Http.conf = conf;
 
 Review comment:
   Well, a static Configuration looks weird. But that's not part of this issue, 
rather speaks for the need rework the protocol-httpclient plugin (see 
NUTCH-1086).
   
   +1 to commit, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix deprecation warnings when building Nutch master branch under JDK 10.0.2+13
> ------------------------------------------------------------------------------
>
>                 Key: NUTCH-2633
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2633
>             Project: Nutch
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.16
>         Environment: java version "10.0.2" 2018-07-17
> Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
> Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)
> Nutch master 01c5d6ea17d7b60d25d4e65462b2a654f10680c3 (Thu Jul 26 14:55:38 
> 2018 +0200)
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.16
>
>
> I just got around to making a dev upgrade to >= JDK 10.
> When building master using environment JDK
> I get several compile time deprecations which are reflected in the attached 
> build log. 
> Additionally, I get some issues with Ivy... see below
> {code}
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by 
> org.apache.ivy.util.url.IvyAuthenticator 
> (file:/Users/lmcgibbn/.ant/lib/ivy-2.3.0.jar) to field 
> java.net.Authenticator.theAuthenticator
> WARNING: Please consider reporting this to the maintainers of 
> org.apache.ivy.util.url.IvyAuthenticator
> WARNING: Use --illegal-access=warn to enable warnings of further illegal 
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> [ivy:resolve] :: problems summary ::
> [ivy:resolve] :::: ERRORS
> [ivy:resolve]         unknown resolver null
> [ivy:resolve]         unknown resolver null
> [ivy:resolve]         unknown resolver null
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to