[
https://issues.apache.org/jira/browse/NUTCH-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657920#comment-16657920
]
ASF GitHub Bot commented on NUTCH-2660:
---------------------------------------
sebastian-nagel closed pull request #397: NUTCH-2660 Plugin tests not executed
URL: https://github.com/apache/nutch/pull/397
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.xml b/build.xml
index 785442a91..e19179e12 100644
--- a/build.xml
+++ b/build.xml
@@ -1061,6 +1061,7 @@
<source path="${plugins.dir}/feed/src/java/" />
<source path="${plugins.dir}/feed/src/test/" />
<source path="${plugins.dir}/headings/src/java/" />
+ <source path="${plugins.dir}/headings/src/test/" />
<source path="${plugins.dir}/exchange-jexl/src/java/" />
<source path="${plugins.dir}/index-anchor/src/java/" />
<source path="${plugins.dir}/index-anchor/src/test/" />
@@ -1104,6 +1105,7 @@
<source path="${plugins.dir}/parse-html/src/java/" />
<source path="${plugins.dir}/parse-html/src/test/" />
<source path="${plugins.dir}/parse-js/src/java/" />
+ <source path="${plugins.dir}/parse-js/src/test/" />
<source path="${plugins.dir}/parse-metatags/src/java/" />
<source path="${plugins.dir}/parse-metatags/src/test/" />
<source path="${plugins.dir}/parse-swf/src/java/" />
diff --git a/default.properties b/default.properties
index d6f606b0c..bb987d966 100644
--- a/default.properties
+++ b/default.properties
@@ -93,6 +93,7 @@ plugins.protocol=\
org.apache.nutch.protocol.http*:\
org.apache.nutch.protocol.httpclient*:\
org.apache.nutch.protocol.interactiveselenium*:\
+ org.apache.nutch.protocol.okhttp*:\
org.apache.nutch.protocol.selenium*:\
org.apache.nutch.protocol.htmlunit*:\
diff --git a/src/plugin/build.xml b/src/plugin/build.xml
index d8e2ef523..d8826e88d 100755
--- a/src/plugin/build.xml
+++ b/src/plugin/build.xml
@@ -113,9 +113,11 @@
<ant dir="any23" target="test"/>
<ant dir="creativecommons" target="test"/>
<ant dir="feed" target="test"/>
+ <ant dir="headings" target="test"/>
<ant dir="index-anchor" target="test"/>
<ant dir="index-basic" target="test"/>
<!--ant dir="index-geoip" target="test"/-->
+ <ant dir="index-jexl-filter" target="test"/>
<ant dir="index-links" target="test"/>
<ant dir="index-more" target="test"/>
<ant dir="index-replace" target="test"/>
@@ -128,6 +130,7 @@
<ant dir="mimetype-filter" target="test"/>
<!--ant dir="parse-ext" target="test"/-->
<ant dir="parse-html" target="test"/>
+ <ant dir="parse-js" target="test"/>
<ant dir="parse-metatags" target="test"/>
<ant dir="parse-swf" target="test"/>
<ant dir="parse-tika" target="test"/>
diff --git a/src/plugin/headings/build.xml b/src/plugin/headings/build.xml
index d334ad1c0..29288e161 100644
--- a/src/plugin/headings/build.xml
+++ b/src/plugin/headings/build.xml
@@ -19,4 +19,22 @@
<import file="../build-plugin.xml"/>
+ <!-- Build compilation dependencies -->
+ <target name="deps-jar">
+ <ant target="jar" inheritall="false" dir="../lib-nekohtml"/>
+ </target>
+
+ <!-- Add compilation dependencies to classpath -->
+ <path id="plugin.deps">
+ <fileset dir="${nutch.root}/build">
+ <include name="**/lib-nekohtml/*.jar" />
+ </fileset>
+ </path>
+
+ <!-- Deploy Unit test dependencies -->
+ <target name="deps-test">
+ <ant target="deploy" inheritall="false" dir="../lib-nekohtml"/>
+ <ant target="deploy" inheritall="false" dir="../nutch-extensionpoints"/>
+ </target>
+
</project>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Unit tests of plugins parse-js, headings, index-jexl-filter to be executed
> during build
> ---------------------------------------------------------------------------------------
>
> Key: NUTCH-2660
> URL: https://issues.apache.org/jira/browse/NUTCH-2660
> Project: Nutch
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 1.15
> Reporter: Sebastian Nagel
> Priority: Minor
> Fix For: 1.16
>
>
> The unit tests of the plugins "parse-js", "headings" and "index-jexl-filter"
> are not executed during build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
