ASF GitHub Bot commented on NUTCH-1403:

sebastian-nagel commented on pull request #458: fix for NUTCH-1403 contributed 
by aalbahem
URL: https://github.com/apache/nutch/pull/458#discussion_r330019665

 File path: src/plugin/scoring-metadata/pom.xml
 @@ -0,0 +1,38 @@
+<?xml version="1.0" encoding="UTF-8"?>
 Review comment:
   Why a pom.xml? Nutch is still built using ant. It shouldn't be included as 
it only confuses users which then try to run "mvn" and wonder why the 
compilation fails or the packages are not bundled properly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add default ScoringFilter for manipulating metadata 
> ----------------------------------------------------
>                 Key: NUTCH-1403
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1403
>             Project: Nutch
>          Issue Type: Improvement
>            Reporter: Julien Nioche
>            Assignee: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.16
> This is currently done by the urlmeta plugin, which has too vague a name and 
> a redundant indexing filter now that we have the index-metadata plugin. This 
> scoring filter would help defining which metadata to pass from : 
> - the crawl metadata to the content metadata
> - the content metadata to the parse metadata
> - the parse metadata to the crawldatum for the outlinks
> I'd make this scoring filter available by default i.e. not in a separate 
> plugin as its functionalities are commonly used.   

This message was sent by Atlassian Jira

Reply via email to