[
https://issues.apache.org/jira/browse/NUTCH-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958574#comment-16958574
]
ASF GitHub Bot commented on NUTCH-2747:
---------------------------------------
balashashanka commented on pull request #482: fix for NUTCH-2747 contributed by
balashashanka
URL: https://github.com/apache/nutch/pull/482
Thanks for your contribution to [Apache Nutch](http://nutch.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Nutch issue
tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`NUTCH-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages
* commits are squashed into a single one (or few commits for larger changes)
* Java source code follows [Nutch Eclipse Code Formatting
rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
* Nutch is successfully built and unit tests pass by running `ant clean
runtime test`
* there should be no conflicts when merging the pull request branch into the
*recent* master branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled master branch.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Nutch
in general, please sign up for the [Nutch mailing
list](http://nutch.apache.org/mailing_lists.html). Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace remaining o.a.commons.logging by org.slf4j
> --------------------------------------------------
>
> Key: NUTCH-2747
> URL: https://issues.apache.org/jira/browse/NUTCH-2747
> Project: Nutch
> Issue Type: Improvement
> Affects Versions: 1.16
> Reporter: Sebastian Nagel
> Priority: Trivial
> Labels: easytask, help-wanted
> Fix For: 1.17
>
>
> A few classes still use logging classes of the package
> org.apache.commons.logging, they should rely on org.slf4j instead, see
> NUTCH-1078. The commons-logging lib is included as a transitive dependency.
> But Nutch classes should not use it. Five classes are found via {{git grep -F
> org.apache.commons.logging}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
