[
https://issues.apache.org/jira/browse/NUTCH-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019024#comment-17019024
]
ASF GitHub Bot commented on NUTCH-2649:
---------------------------------------
sebastian-nagel commented on pull request #496: Fix for NUTCH-2649: Optionally
skip TLS/SSL certificate validation fo…
URL: https://github.com/apache/nutch/pull/496#discussion_r368318737
##########
File path:
src/plugin/protocol-htmlunit/src/java/org/apache/nutch/protocol/htmlunit/HttpResponse.java
##########
@@ -40,6 +42,7 @@
import org.apache.nutch.net.protocols.HttpDateFormat;
import org.apache.nutch.net.protocols.Response;
import org.apache.nutch.protocol.ProtocolException;
+import org.apache.nutch.protocol.httpclient.DummyX509TrustManager;
Review comment:
This import is not available, i.e., the code does not compile. Could verify
this by running `ant clean runtime`?
Plugins are encapsulated and classes from one plugin are not visible in
other plugins except they are explicitly requested in the plugin.xml. However,
in this case we just could copy the DummyX509TrustManager into the package
`org.apache.nutch.protocol.htmlunit`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optionally skip TLS/SSL certificate validation for protocol-selenium and
> protocol-htmlunit
> ------------------------------------------------------------------------------------------
>
> Key: NUTCH-2649
> URL: https://issues.apache.org/jira/browse/NUTCH-2649
> Project: Nutch
> Issue Type: Improvement
> Components: protocol
> Affects Versions: 1.15
> Reporter: Sebastian Nagel
> Assignee: Shashanka Balakuntala Srinivasa
> Priority: Minor
> Fix For: 1.17
>
>
> NUTCH-2648 adds a property to enable/disable the TLS/SSL certificate
> validation for protocol-http, protocol-httpclient and protocol-okhttp. It
> should be also supported by remaining protocol plugins:
> * protocol-selenium,
> * protocol-interactiveselenium and
> * protocol-htmlunit
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
