[
https://issues.apache.org/jira/browse/NUTCH-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091596#comment-17091596
]
ASF GitHub Bot commented on NUTCH-2783:
---------------------------------------
sebastian-nagel opened a new pull request #516:
URL: https://github.com/apache/nutch/pull/516
- replace logging messages with string concatenations by parametrized calls
- remove `LOG.isInfoEnabled()` where parametrized logging is used and no or
minor extra calls are one to get logging parameters (similar for other log
levels)
- replace needless `.toString()` and `Integer.toString(intVal)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use (more) parametrized logging
> -------------------------------
>
> Key: NUTCH-2783
> URL: https://issues.apache.org/jira/browse/NUTCH-2783
> Project: Nutch
> Issue Type: Improvement
> Affects Versions: 1.16
> Reporter: Sebastian Nagel
> Assignee: Sebastian Nagel
> Priority: Trivial
> Fix For: 1.17
>
>
> Nutch uses [slf4j's
> Logger|http://www.slf4j.org/apidocs/org/slf4j/Logger.html] (since NUTCH-851),
> but there are still many places where parametrized logging is not used or
> parameters are needless converted to strings before the call. This issue aims
> to improve the situation for commonly used tools and plugins in order to
> simplify code and improve the [logging
> performance|https://www.slf4j.org/faq.html#logging_performance]. A PR is on
> the way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
