[ https://issues.apache.org/jira/browse/NUTCH-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106184#comment-17106184 ]
Markus Jelsma commented on NUTCH-2419: -------------------------------------- Hello Sebastian! I glanced over the diff and it seems that you are, as usual, quite consistent. The changes seem to apply similarly to the filters. I did spot these weird contraptions though: {code:java} if (file != null) { // take file } else if (attributeFile != null) {code} > Some URL filters and normalizers do not respect command-line override for > rule file > ----------------------------------------------------------------------------------- > > Key: NUTCH-2419 > URL: https://issues.apache.org/jira/browse/NUTCH-2419 > Project: Nutch > Issue Type: Bug > Components: plugin, urlfilter, urlnormalizer > Affects Versions: 1.13 > Reporter: Markus Jelsma > Assignee: Markus Jelsma > Priority: Minor > Fix For: 1.17 > > Attachments: NUTCH-2419.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)