sebastian-nagel commented on pull request #533: URL: https://github.com/apache/nutch/pull/533#issuecomment-642579892
> do you want them squashed immediately > As a reviewer I prefer independant commits to avoir having to re-read everything but the README suggests you prefer to squash everything. I totally agree. It doesn't really matter if the changes are short (as here). But if it's about hundred or more lines of code, separate commits (each with a [meaningful commit message](http://www.commitstrip.com/en/2017/09/12/versioning-is-important/)) are better. Same applies if a larger contribution includes automatic code reformats or refactorings (usually no need to review them, at least, not carefully). > What is the correct way to test such a change to nutch script help? I ran ant zip-bin and redeployed the code locally but maybe there is something faster, working directly in-tree? 1. compile Nutch and build the runtime: `ant runtime` or just `ant` 2. then call `runtime/local/bin/nutch` (have a look at the environment variables in `bin/nutch` which allow to override the log folder or directories where config files are loaded from) Testing of distributed mode is naturally much more complex (eg. see [here](/sebastian-nagel/nutch-test-single-node-cluster)) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
