[
https://issues.apache.org/jira/browse/NUTCH-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157448#comment-17157448
]
ASF GitHub Bot commented on NUTCH-2805:
---------------------------------------
balashashanka commented on a change in pull request #540:
URL: https://github.com/apache/nutch/pull/540#discussion_r454429470
##########
File path: src/plugin/urlfilter-domaindenylist/plugin.xml
##########
@@ -16,13 +16,13 @@
limitations under the License.
-->
<plugin
- id="urlfilter-domainblacklist"
- name="Domain Blacklist URL Filter"
+ id="urlfilter-domaindenylist"
+ name="Domain Denylist URL Filter"
version="1.0.0"
provider-name="nutch.org">
<runtime>
- <library name="urlfilter-domainblacklist.jar">
+ <library name="urlfilter-denyblacklist.jar">
Review comment:
Fixed this thanks....now git grep -F "domainblacklist" , just prints the
CHANGES.txt since I included the changes to the plugin name and field name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Rename plugin urlfilter-domainblacklist
> ---------------------------------------
>
> Key: NUTCH-2805
> URL: https://issues.apache.org/jira/browse/NUTCH-2805
> Project: Nutch
> Issue Type: Sub-task
> Components: plugin, urlfilter
> Reporter: Sebastian Nagel
> Assignee: Shashanka Balakuntala Srinivasa
> Priority: Major
> Fix For: 1.18
>
>
> As part of NUTCH-2802 the plugin {{urlfilter-domainblacklist}} should be
> renamed including variable names in Java classes and the file names of
> configuration files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
