[
https://issues.apache.org/jira/browse/NUTCH-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178599#comment-17178599
]
Hudson commented on NUTCH-2817:
-------------------------------
SUCCESS: Integrated in Jenkins build Nutch ยป Nutch-trunk #3 (See
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/3/])
NUTCH-2817 Avoid check for equality of URL path and file part using ==/!=
(snagel:
[https://github.com/apache/nutch/commit/69deffa67d76eb61ddabe29d54575c5b6635a4e2])
* (edit)
src/plugin/protocol-ftp/src/java/org/apache/nutch/protocol/ftp/FtpResponse.java
* (edit)
src/plugin/protocol-file/src/java/org/apache/nutch/protocol/file/FileResponse.java
> Avoid check for equality of URL path and file part using ==/!=
> --------------------------------------------------------------
>
> Key: NUTCH-2817
> URL: https://issues.apache.org/jira/browse/NUTCH-2817
> Project: Nutch
> Issue Type: Sub-task
> Components: plugin, protocol
> Affects Versions: 1.17
> Reporter: Sebastian Nagel
> Priority: Minor
> Fix For: 1.18
>
>
> In the plugins protocol-file and protocol-ftp Spotbugs warns about
> "Comparison of String objects using == or !=". This is actual a false
> positive since path and file point to the same object for URLs with no query
> part (a query is not supported for file:// and ftp://). To check for
> existence of the query part would be better to understand and also avoids the
> Spotbugs warning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
