[ 
https://issues.apache.org/jira/browse/NUTCH-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285198#comment-17285198
 ] 

ASF GitHub Bot commented on NUTCH-2849:
---------------------------------------

sebastian-nagel commented on a change in pull request #569:
URL: https://github.com/apache/nutch/pull/569#discussion_r576824015



##########
File path: build.xml
##########
@@ -186,6 +186,7 @@
       doctitle="${name} ${version} API"
       bottom="Copyright © ${year} The Apache Software Foundation"
       failonerror="true"
+      failonwarning="true"

Review comment:
       Observed two warnings when running `ant clean javadoc` (which made the 
build to fail):
   ``` 
     [javadoc] .../src/java/org/apache/nutch/protocol/RobotRulesParser.java:58: 
warning - Tag @link: reference not found: getRobotRulesSet
     [javadoc] 
.../src/plugin/indexer-elastic/src/java/org/apache/nutch/indexwriter/elastic/ElasticIndexWriter.java:204:
 warning - Tag @link: reference not found: BulkProcessor.Listener
     ...
     [javadoc] 2 warnings
   
   BUILD FAILED
   .../build.xml:723: Javadoc issued warnings.
   ```

##########
File path: build.xml
##########
@@ -809,6 +811,7 @@
       <classpath>
         <fileset dir="${build.plugins}" >
           <include name="**/*.jar"/>
+          <exclude name="any23/javax.annotation-api*.jar"/>

Review comment:
       Ok. Nice, this solves the remaining "Multiple sources of package 
comments found" warning (see #568).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Replace remaining package.html files with package-info.java
> -----------------------------------------------------------
>
>                 Key: NUTCH-2849
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2849
>             Project: Nutch
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 1.18
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.19
>
>
> Following on from NUTCH-2842, this issue will implement solution # 2 in 
> [~snagel]'s 
> [comment|https://github.com/apache/nutch/pull/568#issuecomment-777298196].
> Once the warnings are gone, we can turn on the *_failonwarning="true"_* flag 
> in the javadoc tasks.
> I'll get to work on this one. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to