[
https://issues.apache.org/jira/browse/NUTCH-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287055#comment-17287055
]
Hudson commented on NUTCH-2850:
-------------------------------
SUCCESS: Integrated in Jenkins build Nutch ยป Nutch-trunk #27 (See
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/27/])
NUTCH-2850 Method ignores exceptional return value (#570) (github:
[https://github.com/apache/nutch/commit/2724578ab41cb9e8098975bddbde7df2085b1c61])
* (edit) src/java/org/apache/nutch/tools/FileDumper.java
> Method ignores exceptional return value
> ---------------------------------------
>
> Key: NUTCH-2850
> URL: https://issues.apache.org/jira/browse/NUTCH-2850
> Project: Nutch
> Issue Type: Sub-task
> Components: dumpers
> Affects Versions: 1.18
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.19
>
>
> In class org.apache.nutch.tools.FileDumper
> In method org.apache.nutch.tools.FileDumper.dump(File, File, String[],
> boolean, boolean, boolean)
> Called method java.io.File.mkdirs()
> At FileDumper.java:[line 237]
> Exceptional return value of java.io.File.mkdirs() ignored in
> org.apache.nutch.tools.FileDumper.dump(File, File, String[], boolean,
> boolean, boolean)
> This method returns a value that is not checked. The return value should be
> checked since it can indicate an unusual or unexpected function execution.
> For example, the File.delete() method returns false if the file could not be
> successfully deleted (rather than throwing an Exception). If you don't check
> the result, you won't notice if the method invocation signals unexpected
> behavior by returning an atypical return value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
