[ 
https://issues.apache.org/jira/browse/NUTCH-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300693#comment-17300693
 ] 

ASF GitHub Bot commented on NUTCH-2857:
---------------------------------------

lewismc opened a new pull request #573:
URL: https://github.com/apache/nutch/pull/573


   This issue proposes to fix https://issues.apache.org/jira/browse/NUTCH-2857
   This results in the following local failures when testing plugins
   ```
   Testsuite: org.apache.nutch.protocol.http.TestProtocolHttp
   Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.336 sec
   ...
   2021-03-12 19:01:53,905 ERROR mortbay.log (Slf4jLog.java:warn(87)) - 
/basic-http.jsp
   java.lang.ClassCastException: class 
jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class 
java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and 
java.net.URLClassLoader are in module java.base of loader 'bootstrap')
        at 
org.apache.jasper.compiler.JspRuntimeContext.<init>(JspRuntimeContext.java:94)
        at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:100)
        at 
org.mortbay.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:440)
        at 
org.mortbay.jetty.servlet.ServletHolder.getServlet(ServletHolder.java:339)
        at 
org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487)
        at 
org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
        at 
org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
        at 
org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
        at 
org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
        at org.mortbay.jetty.Server.handle(Server.java:326)
        at 
org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
        at 
org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
        at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
        at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
        at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
        at 
org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
        at 
org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
   ```
   The same JDK issues are present in the following tests as well
   ```
   Testsuite: org.apache.nutch.protocol.httpclient.TestProtocolHttpClient
   Tests run: 7, Failures: 7, Errors: 0, Skipped: 0, Time elapsed: 1.644 sec
   ```
   and
   ```
   Testsuite: org.apache.nutch.protocol.okhttp.TestProtocolOkHttp
   Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.827 sec
   ```
   Additionally, I think we might want to address deprecation in the Nutch API. 
For example, when I execute a build, I see **59** javac deprecation notices in 
my build log. Maybe we could address that in a separate issue...
   
   Thanks for anyone who can also review this patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Upgrade from JDK1.8 --> JDK11
> -----------------------------
>
>                 Key: NUTCH-2857
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2857
>             Project: Nutch
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.18
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Major
>             Fix For: 1.19
>
>
> I kicked the [JDK1.8 --> JDK11 conversation off on 
> [email protected]|https://lists.apache.org/thread.html/r575b93eb7105c22500deba02ad1b338b30a2dd4d9b2718c18582cb2b%40%3Cdev.nutch.apache.org%3E].
> This issue allows us to flesh it out more and to share some experiences 
> alongside some pull requests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to