[
https://issues.apache.org/jira/browse/NUTCH-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458803#comment-17458803
]
ASF GitHub Bot commented on NUTCH-2916:
---------------------------------------
lewismc commented on pull request #714:
URL: https://github.com/apache/nutch/pull/714#issuecomment-993019616
+1
On Mon, Dec 13, 2021 at 14:44 Sebastian Nagel ***@***.***>
wrote:
>
> - nutch.log replaces hadoop.log as default log file name
> - file rotation patterns only match nutch.log as log file name
> - checking on start-up whether the log file(s) need to be rotated
>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/nutch/pull/714
> Commit Summary
>
> - 336d87a
>
<https://github.com/apache/nutch/pull/714/commits/336d87a27c4dc5a19e8cfc6df86cdde04ceb2f74>
> NUTCH-2916 Fix log file rotation / rename default log file
>
> File Changes
>
> (2 files <https://github.com/apache/nutch/pull/714/files>)
>
> - *M* conf/log4j2.xml
>
<https://github.com/apache/nutch/pull/714/files#diff-17aeab886ba9761c2c55352f23de2485be0ce528c5117bee63f7189dced8163a>
> (3)
> - *M* src/bin/nutch
>
<https://github.com/apache/nutch/pull/714/files#diff-263657e2b952f64ae9b81733530522b922214f6ebc9686fbd2e4ec368c2cabd8>
> (3)
>
> Patch Links:
>
> - https://github.com/apache/nutch/pull/714.patch
> - https://github.com/apache/nutch/pull/714.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nutch/pull/714>, or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAI4TFZBBKDRIUKW26ZCMXLUQZZMBANCNFSM5J7L6UKQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
http://home.apache.org/~lewismc/
http://people.apache.org/keys/committer/lewismc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix log file rotation / rename default log file
> -----------------------------------------------
>
> Key: NUTCH-2916
> URL: https://issues.apache.org/jira/browse/NUTCH-2916
> Project: Nutch
> Issue Type: Bug
> Components: logging
> Affects Versions: 1.19
> Reporter: Sebastian Nagel
> Assignee: Sebastian Nagel
> Priority: Major
> Fix For: 1.19
>
>
> The log file rotation isn't working after the upgrade to log4j 2.x
> (NUTCH-2885):
> - the rotation patterns need to fit with (default) log file name: I'd propose
> now (was wrong in the discussion of [#692|github.com/apache/nutch/pull/692])
> to use "nutch.log" as default name and to drop the old "hadoop.log"
> - file rotation should be also done on start-up
> Will open a PR...
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
