[ 
https://issues.apache.org/jira/browse/NUTCH-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723381#comment-17723381
 ] 

Sebastian Nagel commented on NUTCH-2991:
----------------------------------------

Thanks, [~marcos] !  At a first glance, the patch looks good. I'll test it 
later. Just few comments:
- maybe change the variable name "headerName" / "headerValue" to 
"authHeaderName", as they are used to set the "Authorization" header?
- would be good to add the new configuration parameters to 
{{conf/index-writers.xml.template}}, with a short comment how to use them, but 
commented out or with empty values.
- can you apply the code style template ({{eclipse-codeformat.xml}}  on the 
root of the Nutch source tree)? If not, no problem, just let us know.


> Support HTTP/S Header Authorization for Solr connections
> --------------------------------------------------------
>
>                 Key: NUTCH-2991
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2991
>             Project: Nutch
>          Issue Type: New Feature
>          Components: indexer, plugin
>    Affects Versions: 1.19
>            Reporter: Marcos Gomez
>            Priority: Major
>             Fix For: 1.20
>
>         Attachments: solr_token_auth.patch
>
>
> Currently only Basic Authentication is possible with Solr, but I have an 
> issue to connect to a Solr instance that use Token authentication.
> So it should be possible to define the value of Authorization Header to 
> provide the name and token value, that will be send on the HTTP request to 
> Solr.
> Header:
>  * Authorization: _Name Value_
> So in the configuration should be able to set up something like this to 
> populate the header: 
>  * solr.auth.header.name=Bearer
>  * solr.auth.header.value=JWT_TOKEN
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to