lewismc commented on PR #791: URL: https://github.com/apache/nutch/pull/791#issuecomment-1778548551
OK, I'm over the bulk of the work here. A brief synopsis of what has been done so far... * new junit5 jupiter dependencies added to `ivy.xml` * All assertions migrated to new `org.junit.jupiter.api.Assertions` package * All annotations migrated to new `org.junit.jupiter.api` package e.g. `@Test` * `@Before` and `@After` no longer exist; migrated to `@BeforeEach` and `@AfterEach` * `@Ignore` no longer exists: migrated to `@Disabled` but we should definitely review these cases and see if we can activate them I think we may be able to improve test execution by investigate parallel execution but that will come in a subsequent PR Additionally, loads of tests are failing right now due to my limited understanding of how to migrate from Ant's legacy [junit task](https://ant.apache.org/manual/Tasks/junit.html) to the junit5 [junitlauncher task](https://ant.apache.org/manual/Tasks/junitlauncher.html). I think one more push and this PR should be ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
