[ 
https://issues.apache.org/jira/browse/NUTCH-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839186#comment-17839186
 ] 

ASF GitHub Bot commented on NUTCH-3041:
---------------------------------------

lewismc commented on PR #813:
URL: https://github.com/apache/nutch/pull/813#issuecomment-2067543713

   The logging now looks as follows
   ```INFO o.a.n.n.URLExemptionFilters [LocalJobRunner Map Task Executor #0] 
Found 1 URLExemptionFilter implementations: 
'[org.apache.nutch.urlfilter.ignoreexempt.ExemptionUrlFilter@3090c372]’```.
   If no URLExemptionFilter implementations are found then no log statement is 
produced. 




> Address confusing logging in o.a.n.net.URLExemptionFilters 
> -----------------------------------------------------------
>
>                 Key: NUTCH-3041
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3041
>             Project: Nutch
>          Issue Type: Task
>          Components: net
>    Affects Versions: 1.19, 1.20
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Minor
>             Fix For: 1.21
>
>
> URLExemptionFilter impementations are used to allow exemptions to external 
> domain resources by overriding the {{db.ignore.external.links}} configuration 
> setting. This is useful when the crawl is focused to a domain but resources 
> like images are hosted on CDN.
> Currently [URLExemptionFilters|#L47-L48]] provides the following logging
> {quote}INFO o.a.n.n.URLExemptionFilters [LocalJobRunner Map Task Executor 
> #0|#0] Found 0 extensions at point:'org.apache.nutch.net.URLExemptionFilter'
> {quote}
> I find this confusing. It would be better to log *only* if an 
> URLExemptionFilter implementation is actually configured to be used at 
> runtime.
> I will provide a patch for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to