[
https://issues.apache.org/jira/browse/NUTCH-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880239#comment-17880239
]
Markus Jelsma commented on NUTCH-1806:
--------------------------------------
Yes, this seems fine when glancing at it. But i must say, it seems odd to
return an empty String instead of null when nothing is found. +1
> Delegate processing of URL domains to crawler commons
> -----------------------------------------------------
>
> Key: NUTCH-1806
> URL: https://issues.apache.org/jira/browse/NUTCH-1806
> Project: Nutch
> Issue Type: Improvement
> Affects Versions: 1.8
> Reporter: Julien Nioche
> Priority: Major
> Labels: crawler-commons
> Fix For: 1.21
>
>
> We have code in src/java/org/apache/nutch/util/domain and a resource file
> conf/domain-suffixes.xml to handle URL domains. This is used mostly from
> URLUtil.getDomainName.
> The resource file is not necessarily up to date and since crawler commons has
> a similar functionality we should use it instead of having to maintain our
> own resources.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
