lewismc commented on code in PR #826:
URL: https://github.com/apache/nutch/pull/826#discussion_r1799894039
##########
conf/log4j2.xml:
##########
@@ -25,7 +25,8 @@
<Appenders>
<RollingFile name="RollingFile"
fileName="${hadoop.log.dir}/${hadoop.log.file}"
filePattern="${hadoop.log.dir}/$${date:yyyy-MM}/nutch-%d{yyyy-MM-dd}.log.gz">
- <PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />
+ <!--<PatternLayout pattern="%d %p %c{1.} [%t] %m%n" />-->
+ <PatternLayout pattern="%d %p %c [%t] %m%n" />
Review Comment:
OK
##########
src/plugin/protocol-smb/ivy.xml:
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0" ?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<ivy-module xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:noNamespaceSchemaLocation="http://ant.apache.org/ivy/schemas/ivy.xsd";
+ xmlns:ns0="http://ant.apache.org/ivy/maven"; version="2.0">
+ <info organisation="org.apache.nutch" module="${ant.project.name}">
+ <license name="Apache 2.0"/>
+ <ivyauthor name="Apache Nutch Team" url="http://nutch.apache.org"/>
+ <description>
+ Apache Nutch
+ </description>
+ </info>
+
+ <configurations>
+ <include file="../../..//ivy/ivy-configurations.xml"/>
+ </configurations>
+
+ <publications>
+ <!--get the artifact from our module name-->
+ <artifact conf="master"/>
+ </publications>
+
+ <dependencies>
+ <dependency org="com.hierynomus" name="smbj" rev="0.13.0"/>
+ <dependency org="net.engio" name="mbassador" rev="1.3.0"/>
Review Comment:
Absolutely, I understand.
_Some_ plugins contain a file called _howto_upgrade_${plugin}.md_ which
contains guidance on this. We could/should extract all of these files to a
centralized location.
For an example you can see
[howto_upgrade_solr.md](https://github.com/apache/nutch/blob/master/src/plugin/indexer-solr/howto_upgrade_solr.md).
##########
src/plugin/protocol-smb/plugin.xml:
##########
@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<plugin
+ id="protocol-smb"
+ name="SMB Protocol based on https://github.com/hierynomus/smbj";
+ version="1.0.0"
+ provider-name="Hiran Chaudhuri">
+
+ <runtime>
+ <library name="asn-one-0.6.0.jar"/>
Review Comment:
If you follow the guidance I gave above regarding adapting the steps in
[howto_upgrade_solr.md](https://github.com/apache/nutch/blob/master/src/plugin/indexer-solr/howto_upgrade_solr.md)
then this stage will be done for you.
##########
src/plugin/build.xml:
##########
@@ -78,6 +78,7 @@
<ant dir="protocol-httpclient" target="deploy"/>
<ant dir="protocol-interactiveselenium" target="deploy" />
<ant dir="protocol-okhttp" target="deploy"/>
+ <ant dir="protocol-smb" target="deploy"/>
Review Comment:
If you look in the same file further down, you will find the
[test](https://github.com/apache/nutch/blob/master/src/plugin/build.xml#L115)
and
[clean](https://github.com/apache/nutch/blob/master/src/plugin/build.xml#L178)
targets.
##########
.gitignore:
##########
@@ -26,3 +26,7 @@ lib/spotbugs-*
ivy/dependency-check-ant/*
.gradle*
ivy/apache-rat-*
+.vscode
+crawl
Review Comment:
Ar you referring to the [Nutch
tutorial](https://cwiki.apache.org/confluence/display/NUTCH/NutchTutorial)?
The tutorial is not aimed towards _developers_ per say so it is not
concerned with accidentally committing these directories along with a PR.
I understand why you have added them in your local branch but they should
not be included in the PR. Each developer may locate the same directories in
different places...
##########
runNutch.sh:
##########
@@ -0,0 +1,32 @@
+#/bin/bash
Review Comment:
OK
##########
src/plugin/protocol-smb/ivy.xml:
##########
@@ -0,0 +1,47 @@
+<?xml version="1.0" ?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<ivy-module xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:noNamespaceSchemaLocation="http://ant.apache.org/ivy/schemas/ivy.xsd";
+ xmlns:ns0="http://ant.apache.org/ivy/maven"; version="2.0">
+ <info organisation="org.apache.nutch" module="${ant.project.name}">
+ <license name="Apache 2.0"/>
+ <ivyauthor name="Apache Nutch Team" url="http://nutch.apache.org"/>
+ <description>
+ Apache Nutch
+ </description>
+ </info>
+
+ <configurations>
+ <include file="../../..//ivy/ivy-configurations.xml"/>
+ </configurations>
+
+ <publications>
+ <!--get the artifact from our module name-->
+ <artifact conf="master"/>
+ </publications>
+
+ <dependencies>
+ <dependency org="com.hierynomus" name="smbj" rev="0.13.0"/>
+ <dependency org="net.engio" name="mbassador" rev="1.3.0"/>
+ <dependency org="org.bouncycastle" name="bcprov-jdk18on" rev="1.75"/>
+ <dependency org="com.hierynomus" name="asn-one" rev="0.6.0"/>
+ <dependency org="commons-io" name="commons-io" rev="2.17.0"/>
Review Comment:
Yes please ignore this comment apologies. That being said with `commons-io`
already defined in `ivy/ivy.xml` we can remove it from the plugin or at-least
synchronize the version with the version set in `ivy/ivy.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
