sebastian-nagel commented on code in PR #829:
URL: https://github.com/apache/nutch/pull/829#discussion_r1800862829


##########
src/java/org/apache/nutch/crawl/Injector.java:
##########
@@ -402,40 +402,38 @@ public void inject(Path crawlDb, Path urlDir, boolean 
overwrite,
 
     // lock an existing crawldb to prevent multiple simultaneous updates
     Path lock = CrawlDb.lock(conf, crawlDb, false);

Review Comment:
   See the discussion in NUTH-3078: moving the creating of the lockfile down 
just before the job is run would avoid that a failure during job configuration 
leads to a lost lockfile.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to