[
https://issues.apache.org/jira/browse/NUTCH-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015729#comment-18015729
]
ASF GitHub Bot commented on NUTCH-3122:
---------------------------------------
lewismc commented on PR #859:
URL: https://github.com/apache/nutch/pull/859#issuecomment-3215516449
@TamimEhsan thanks for providing the additional context. You missed no steps
in the contribution. The contribution is excellent thank you.
Because we own the `SpellCheckedMetadata` Class I think it is OK to mock it.
Thanks for proposing the additional test. Some documentation to accompany
the test would be great.
> Make SpellCheckedMetadata case-insensitive for all Metadata names
> -----------------------------------------------------------------
>
> Key: NUTCH-3122
> URL: https://issues.apache.org/jira/browse/NUTCH-3122
> Project: Nutch
> Issue Type: Improvement
> Components: metadata
> Affects Versions: 1.21
> Reporter: Sebastian Nagel
> Priority: Major
> Fix For: 1.22
>
>
> See NUTCH-3002 and the discussion in
> [stormcrawler#1588|https://github.com/apache/stormcrawler/issues/1588]:
> - we have CaseInsensitiveMetadata (used by protocol-okhttp) and
> - SpellCheckedMetadata (used elsewhere) which does case-insensitive look-ups
> only for header listed in
> [HttpHeaders|https://github.com/apache/nutch/blob/master/src/java/org/apache/nutch/metadata/HttpHeaders.java]
> We might consider to make SpellCheckedMetadata case-insensitive in general.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
