igiguere commented on PR #880: URL: https://github.com/apache/nutch/pull/880#issuecomment-3724530642
> Hi @igiguere, thanks for this fix of a long outstanding bug! Highly appreciated! > > There are only few minor points which should be improved, see the inline comments. > > One additional point: there are "deactivated" unit tests for [NUTCH-1564](https://issues.apache.org/jira/browse/NUTCH-1564) implemented as part of [NUTCH-1502](https://issues.apache.org/jira/browse/NUTCH-1502). Maybe you can move the unit tests from [TODOTestCrawlDbStates.java](https://github.com/apache/nutch/blob/master/src/test/org/apache/nutch/crawl/TODOTestCrawlDbStates.java) into TestCrawlDbStates.java and then delete the class TODOTestCrawlDbStates.java. You can then verify whether the "activated" unit tests pass per `ant test-core -Dtestcase=TestCrawlDbStates`. Thanks! Done. I renamed TODOTestCrawlDbStates as TestCrawlDbStatesExtended to avoid a clash with the existing TestCrawlDbStates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
