igiguere commented on PR #891: URL: https://github.com/apache/nutch/pull/891#issuecomment-3954928830
> This was a really good refresher for me as well. It touches parts of the codebase I hadn't looked at for a while... but I must admit, it took me a while. I was scratching my head in the debugger for ages. @igiguere also, apologies my comment above was a bit short. No need to apologize at all. Solid peer review is the beauty of open source and definitely the part thats had the most impact on me personally. Please ping me if and when you want more peer review. Thank you. @lewismc I fixed `IndexerMapReduce`, so it is now properly configured. I improved test for failed parsing in `TestCrawlDbStates` and `TestIndexerMapReduce`. The new test `TestFetchWithParseFailure` "should" test the fetcher, but it strangely does not fully run most of the time. It's disabled while thinking of a solution. Feel free to pitch in with ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
