[
https://issues.apache.org/jira/browse/NUTCH-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061476#comment-18061476
]
Hudson commented on NUTCH-3160:
-------------------------------
SUCCESS: Integrated in Jenkins build Nutch » Nutch-trunk #229 (See
[https://ci-builds.apache.org/job/Nutch/job/Nutch-trunk/229/])
[NUTCH-3160] Remove System.exit(..) from reusable code (#903) (github:
[https://github.com/apache/nutch/commit/da557082662227cde52959652f406446496044da])
* (edit) src/test/org/apache/nutch/tools/TestCommonCrawlDataDumper.java
* (edit) src/java/org/apache/nutch/tools/CommonCrawlDataDumper.java
* (edit) src/java/org/apache/nutch/metrics/NutchMetrics.java
> Leftover System.exit(..) in CommonCrawlDataDumper
> -------------------------------------------------
>
> Key: NUTCH-3160
> URL: https://issues.apache.org/jira/browse/NUTCH-3160
> Project: Nutch
> Issue Type: Bug
> Affects Versions: 1.22
> Reporter: Luca Foppiano
> Assignee: Luca Foppiano
> Priority: Minor
> Fix For: 1.23
>
>
> Hi all,
> this is my first issue here.
> Just a small leftover from NUTCH-2852
> There is a `System.exit()` instead of a `return` in
> `CommonCrawlDataDumper.dump()`, this usually kills the test that is calling
> the method.
> ```
> LinkDbReader linkDbReader = null;
> if (linkdb != null) {
> linkDbReader = new LinkDbReader(nutchConfig, new
> Path(linkdb.toString()));
> }
> if (parts == null || parts.size() == 0) {
> LOG.error( "No segment directories found in {} ",
> segmentRootDir.getAbsolutePath());
> System.exit(1);
> }
> LOG.info("Found {} segment parts", parts.size());
> if (gzip && !warc) {
> fileList = new ArrayList<>();
> constructNewStream(outputDir);
> }
> ```
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
