[
https://issues.apache.org/jira/browse/NUTCH-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118182#comment-18118182
]
ASF GitHub Bot commented on NUTCH-3211:
---------------------------------------
lewismc merged PR #966:
URL: https://github.com/apache/nutch/pull/966
> Skip SonarCloud when test artifacts are absent; pin Ubuntu runners before
> ubuntu-latest moves to 26.04
> ------------------------------------------------------------------------------------------------------
>
> Key: NUTCH-3211
> URL: https://issues.apache.org/jira/browse/NUTCH-3211
> Project: Nutch
> Issue Type: New Feature
> Components: ci/cd
> Affects Versions: 1.23
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Minor
> Fix For: 1.24
>
>
> When master pull request CI succeeds but uploads no Ubuntu JDK 17 artifacts
> (path-filtered changes, so tests never run), the follow-up workflows disagree:
> * junit report succeeds after skipping the PR comment / publish steps, but
> dawidd6/action-download-artifact still records a failure annotation ("no
> artifacts found") because if_no_artifact_found defaults to fail and the step
> only continues via continue-on-error.
> * sonarcloud fails on the first download
> (build-artifacts-ubuntu-latest-jdk17) with the same annotation, so
> coverage/JUnit download and the scan never run.
> Those two workflows should treat a missing artifact the same way: notice,
> skip remaining work, job success, no failure annotation. If binaries were
> uploaded but JaCoCo or JUnit XML is missing, SonarCloud should still fail.
> Separately, every Nutch workflow uses ubuntu-latest. GitHub will migrate that
> label from Ubuntu 24.04 to 26.04 between 19 October and 19 November 2026
> (runner-images#14748), which already annotates runs. Pin Ubuntu jobs to
> ubuntu-24.04 and stop encoding the runner label in artifact names
> (build-artifacts-ubuntu-latest-jdk17 /
> junit-test-results-ubuntu-latest-jdk17) so a later OS bump does not break
> JUnit/Sonar downloads.
> Example runs:
> * https://github.com/apache/nutch/actions/runs/35399262856 (junit report)
> * https://github.com/apache/nutch/actions/runs/35399262933 (sonarcloud)
> * Parent: https://github.com/apache/nutch/actions/runs/35399070344
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
