lewismc opened a new pull request, #974: URL: https://github.com/apache/nutch/pull/974
This PR addresses the remainder of [NUTCH-3215](https://issues.apache.org/jira/browse/NUTCH-3215). The first pull request only removed trailing spaces. Yetus treats "end in blanks" as any trailing space or tab, and it has a second, separate vote for tab characters anywhere in a line. Both of those were still present after #971 merged. Whilst I was looking at this, I was curious about whether the Eclipse profile in `eclipse-codeformat.xml` and Yetus agreed/disagreed on anything.The Eclipse profile sets `tabulation.char` to space, with both `tabulation.size` and `indentation.size` at `2`. Yetus blanks fails a file that contains a tab character, or a line that ends in a space or a tab. A Java file formatted with that profile satisfies both of those checks. Yetus does not care that the indent is 2 rather than 4, and it does not apply the Eclipse line length of 80. Two limits keep them from being the same convention: - The Eclipse profile formats Java only. Yetus blanks scans the whole tree, including XML, HTML, shell scripts, and properties files. Those files are aligned with Yetus only if they also use spaces and have no trailing blanks. The tab-delimited data files listed in .yetus/blanks-tabs.txt are an intentional exception. - Because .yetus/blanks-tabs.txt exists, Yetus uses that file instead of its built-in exceptions for Makefiles and Go. This repository does not list those patterns. A Makefile that uses tabs for recipes would fail Yetus even though that is normal Make, and the Eclipse profile would not touch it. After running Yetus locally everything checks out ``` mkdir -p /tmp/nutch-yetus-out docker run --rm \ -v "$PWD":/src \ -v /tmp/nutch-yetus-out:/out \ -w /src \ ghcr.io/apache/yetus:0.15.1 \ test-patch \ --basedir=/src \ --patch-dir=/out \ --build-tool=nobuild \ --plugins=blanks \ --empty-patch \ --project=nutch \ --blanks-eol-ignore-file=.yetus/blanks-eol.txt \ --blanks-tabs-ignore-file=.yetus/blanks-tabs.txt \ --java-home=/usr/lib/jvm/java-11-openjdk-amd64 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
