handecelikkanat opened a new pull request, #987: URL: https://github.com/apache/nutch/pull/987
Add the runtime dependencies of Testcontainers (docker-java*, duct-tape*, jna*) to the global test dependencies in src/plugin/build-plugin.xml, so the Testcontainers-based protocol integration tests run instead of being skipped. See https://issues.apache.org/jira/browse/NUTCH-3233. With this change, locally with Docker running: - HttpProtocolIT: 3 tests, 0 failures - OkHttpProtocolIT: 3 tests, 0 failures - HtmlUnitProtocolIT: 3 tests, 1 failure (testFetchReturnsContent), reported as https://issues.apache.org/jira/browse/NUTCH-3234 - SeleniumProtocolIT: 3 tests, 3 failures, reported as https://issues.apache.org/jira/browse/NUTCH-3235 I left both tests unchanged. Once this PR is merged, PRs touching protocol plugins will fail these tests until NUTCH-3234 and NUTCH-3235 are fixed or the tests are disabled. Unit tests (ant clean runtime test) pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
