[
https://issues.apache.org/jira/browse/NUTCH-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136124#comment-18136124
]
ASF GitHub Bot commented on NUTCH-3233:
---------------------------------------
github-actions[bot] commented on PR #987:
URL: https://github.com/apache/nutch/pull/987#issuecomment-6559335925
## Apache Yetus test-patch report
| |
|------------|
| +1 overall |
| | | | |
|
|------|------------|---------|-----|---------------------------------------------------|
| Vote | Subsystem | Runtime | Log | Comment
|
| | | | | Prechecks
|
| +1 | dupname | 0m 0s | | No case conflicting files found.
|
| +1 | @author | 0m 0s | | The patch does not contain any @author
tags. |
| | | | | master Compile Tests
|
| | | | | Patch Compile Tests
|
| +1 | codespell | 0m 2s | | No new issues.
|
| +1 | detsecrets | 0m 31s | | No new issues.
|
| +1 | blanks | 0m 0s | | The patch has no blanks issues.
|
| +1 | xmllint | 0m 0s | | No new issues.
|
| | | | | Other Tests
|
| +1 | asflicense | 0m 1s | | The patch does not generate ASF
License warnings. |
| | | 0m 38s | |
|
| |
|
|----------------|---------------------------------------------------------------------------------------------------------------------------------|
| Subsystem | Report/Notes
|
| GITHUB PR | https://github.com/apache/nutch/pull/987
|
| Optional Tests | dupname asflicense codespell detsecrets xmllint
|
| uname | Linux 395e3f05a75f 7.0.0-1017-azure \#17~24.04.1-Ubuntu
SMP PREEMPT Thu Sep 24 18:46:57 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild
|
| Personality | /github/workspace/.yetus/personality.sh
|
| git revision | master / 343e05d556b61d2ced8d1a240f05f9b776002386
|
| modules | C: . U: .
|
| versions | git=2.34.1 codespell=2.4.1 detsecrets=1.5.0 xmllint=20913
|
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org
|
This message was automatically generated.
<!
> Testcontainers protocol integration tests are skipped because Testcontainers'
> dependencies are missing from the plugin test classpath
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NUTCH-3233
> URL: https://issues.apache.org/jira/browse/NUTCH-3233
> Project: Nutch
> Issue Type: Bug
> Components: build
> Affects Versions: 1.23
> Reporter: Hande Celikkanat
> Priority: Major
>
> The protocol plugin integration tests that use Testcontainers (HttpProtocolIT,
> HtmlUnitProtocolIT, OkHttpProtocolIT, SeleniumProtocolIT, added in NUTCH-3175)
> are skipped even when Docker is available, for example:
> {noformat}
> ant test-protocol-integration
> ...
> [echo] Running protocol integration tests for plugin: protocol-selenium
> [junitlauncher] Tests run: 0, Failures: 0, Aborted: 0, Skipped: 3, Time
> elapsed: 0.111 sec
> {noformat}
> test.classpath in src/plugin/build-plugin.xml includes only
> testcontainers*.jar
> from build/test/lib, not the runtime dependencies of Testcontainers
> (docker-java-api, docker-java-transport, docker-java-transport-zerodep,
> duct-tape, jna). Testcontainers cannot load its Docker client, and its JUnit
> extension (@Testcontainers(disabledWithoutDocker = true)) treats that as "no
> Docker available" and skips the tests. The indexer plugins should not be
> affected, because they declare Testcontainers modules in their own ivy.xml,
> which brings these dependencies into the plugin's test lib.
> Adding include patterns for docker-java*.jar, duct-tape*.jar and jna*.jar
> makes
> the tests run. These cover the declared runtime dependencies of Testcontainers
> 2.0.5 and docker-java-transport-zerodep 3.7.1. slf4j-api and commons-compress
> are already on the classpath via build/lib, and jib-core is a provided
> dependency.
> With the tests enabled, HtmlUnitProtocolIT.testFetchReturnsContent fails:
> getProtocolOutput returns no content for a live nginx page. This needs a look
> before or together with this fix.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
