sebastian-nagel commented on code in PR #994:
URL: https://github.com/apache/nutch/pull/994#discussion_r4528801897
##########
src/java/org/apache/nutch/tools/CommonCrawlDataDumper.java:
##########
@@ -334,7 +334,8 @@ public void dump(File outputDir, File segmentRootDir, File
linkdb, boolean gzip,
reverseKey, url, timestamp, extensionName, !gzip);
outputRelativePath = outputFullPath
.substring(0, outputFullPath.lastIndexOf(File.separator) -
1);
- filename = content.getMetadata().get(Metadata.DATE) + "."
Review Comment:
But that's another issue. To be addressed in NUTCH-3251.
##########
src/java/org/apache/nutch/tools/CommonCrawlDataDumper.java:
##########
Review Comment:
Hm. Either it's `"Date"`...
##########
src/java/org/apache/nutch/tools/CommonCrawlDataDumper.java:
##########
@@ -334,7 +334,8 @@ public void dump(File outputDir, File segmentRootDir, File
linkdb, boolean gzip,
reverseKey, url, timestamp, extensionName, !gzip);
outputRelativePath = outputFullPath
.substring(0, outputFullPath.lastIndexOf(File.separator) -
1);
- filename = content.getMetadata().get(Metadata.DATE) + "."
Review Comment:
... or `"date"` which `Metadata.DATE` is set to.
Because Metadata is case-sensitive it cannot work both ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]