+1 On Sun, Dec 22, 2019, 15:57 Xiang Xiao <xiaoxiang781...@gmail.com> wrote:
> +1. > It's impotant to let people start the contribution. > The committer could/should do more work to ensure the correction in > review process before the automation tool is ready. > > Thanks > Xiang > > On Sun, Dec 22, 2019 at 8:57 PM David Sidrane <davi...@apache.org> wrote: > > > > This works! > > > > On 2019/12/22 02:05:56, Brennan Ashton <bash...@brennanashton.com> > wrote: > > > I really want to let people to contribute (myself included) ASAP so I > was > > > to propose this as an option to get going and can be amended later. I > know > > > it does not resolve all the issues, but offers what I think is a > reasonable > > > avenue to get started. > > > > > > Submit a PR on GitHub against master if it is approved by one commiter > > > (that did not propose it) > > > > This is key! We need the eyes (and possibly the hands) of the subject > matter experts, reviewing, commenting and possible fixing submissions. > > > > >it can be merged. The approval is done via the > > > GitHub approval system. > > +1 > > > > > > A commiter may create a PR on behalf of a patch submitted to the > mailing > > > list. > > +1 > > > > > > Commiters can ask for others to review or approve. But at the end of > the > > > day they are the ones who approve and merge. > > +1 > > > > > > We can and should amend this later, it is likely not enough long term. > > > > > > Could people vote if they think this is fine to start. If you don't > agree > > > just note that and we can review where we are at. > > > > > > --Brennan > > > >
