patacongo commented on a change in pull request #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573
########## File path: tools/Makefile.unix ########## @@ -192,11 +192,18 @@ NUTTXNAME = nuttx BIN = $(NUTTXNAME)$(EXEEXT) all: $(BIN) -.PHONY: dirlinks context clean_context check_context config oldconfig menuconfig nconfig qconfig gconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean +.PHONY: dirlinks context clean_context check_context config oldconfig menuconfig nconfig qconfig gconfig export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean check_format ifeq ($(GIT_DIR),y) Review comment: For all of these.. same changes should be applied to Makefile.win. No is using Makefile.win now, but we don't want it to get too far out of sync. If is does not involve bash commands, the change is a simple copy-paste. Bash and core-utils commands would need to be replaced with the CMD.com equivalent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
