xiaoxiang781216 commented on issue #2: Master pr nxstyle improvments URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568378194 @btashton @davids5 What I mean here is that we don't need modify Makefile, is engouh to add a script invoke nxstyle(maybe build it too) to check the style for specific file/files or commit/commits. Then we instruct people integrate this script into pre-commit hook to enable the check automatically. Like: https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl Nobody try to integrate checkpatch.pl into Linux build system, since developer can run checkpatch.pl directly to: 1.The bunch of specified files 2.The bunch of specified commits 3.The current living change 4.Integrate to pre-commit hook It's much flexible than make check_format since we can pass the different argument to script form command line, but the same thing is hard to do for Makefile.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
