Hi, > The style fix should be in one patch not the separated patch. If the > new code has the style problem, contributor should fix it and resend > PR again.
While generally if you broke something (like a build) you should be the one to fix it, it’s more encouraging to help out new contributors. In some cases that may mean a committer or PMC member needs to fix a patch to show them what to do in future patches. The users and contributors should be your primary focus. Telling someone to jump through hoops they don’t understand may drive them away, helping them understand what required for future patches/PRs is often better. A poor quality patch can be better than no patch at all, as it may contain a great idea or an important fix, people can collaborate and fine tune it and fix it before it is committed / merged. > Nobody has the right bypass the criticia we will define in the > workflow document and merge the patch(even it just fix the style > issue) directly. Like all guidelines there may be some cases, when this needs to be bypassed e.g urgent security issue or broken build. It certainly should come with a good explanation to why this was needed, but it's better to follow good guideline than have absolute rules. Thanks, Justin
