On Fri, Dec 27, 2019 at 10:45 AM Xiang Xiao <xiaoxiang781...@gmail.com> wrote: > On Fri, Dec 27, 2019 at 10:59 PM David Sidrane <david.sidr...@nscdg.com> > wrote: > > Notice what happened in the repo. > > Yes, you manually create a branch in official repo without any review process. > > > See https://github.com/apache/incubator-nuttx-website/branches > > > > Now do you see why the argument makes sense? > > > > No, since the normal contributor even don't have right to modify > anything in official repo. Only committer can hit this issue, you just > abuse the committer power. > This also demonstrate PX4 workflow encourage people modify the > official repo directly just like local fork, I don't think it's a good > habit. > > > Are we going to prohibit this? Think about the ramification. We as > > committers will not be able to use the UI when it makes sense. > > Of course, we should prohibit any modification which doesn't pass the > review process like this enter the repo. > You can do anything in your fork with UI, but shouldn't mess up the > official repo. > Many people will sync up with the official repo, any partial or stale > work just make the newbie confusion.
Exactly. Any changes you want to make (whether you are a committer or not): * If you are using GitHub, make a fork, make your changes in your fork, open a PR. * If you are using git, make a clone, make your changes in your clone, send a 'git request-pull' or 'git format-patch'. * If you are using no SCM / other SCM, get the release tarball, make your changes, produce a patch. Committers are not allowed to bypass the above and put stuff directly in the repo without going through the same process and review as everyone else. Nathan
