davids5 opened a new pull request #12: nxstyle improvements with No tooling URL: https://github.com/apache/incubator-nuttx/pull/12 - Added features - outputs parse-able compiler like error format - Uses getops to parse command line. - Supports -s silence all output -g provide a PASS fail message test script to check the whole of nuttx ``` #!/bin/bash LIST=$(find ../ -type f \( -iname \*.c -o -iname \*.h \)) for f in $LIST; do ./nxstyle -g -m 80 $f; done ``` Good new 4000 files pass. ``` ./test.sh 2>&1 | grep PASSED | wc -l 4000 ``` BAD new 5298 files fail. ``` ./test.sh 2>&1 | grep FAIL | wc -l 5298 ``` # Test cases ## Test case 1 ironic but true `./nxstyle -m 99 nxstyle-master.c ` ``` nxstyle-master.c:316:11: error: Bad alignment nxstyle-master.c:319:13: error: Bad left brace alignment nxstyle-master.c:320:15: error: Bad comment alignment nxstyle-master.c:321:16: error: Bad comment block alignment nxstyle-master.c:322:16: error: Bad comment block alignment nxstyle-master.c:323:16: error: Bad comment block alignment nxstyle-master.c:325:15: error: Bad alignment nxstyle-master.c:329:17: error: Bad left brace alignment nxstyle-master.c:333:17: error: Bad right brace alignment nxstyle-master.c:335:15: error: Bad comment alignment nxstyle-master.c:336:16: error: Bad comment block alignment nxstyle-master.c:337:16: error: Bad comment block alignment nxstyle-master.c:338:16: error: Bad comment block alignment nxstyle-master.c:339:16: error: Bad comment block alignment nxstyle-master.c:341:15: error: Bad alignment nxstyle-master.c:342:17: error: Bad left brace alignment nxstyle-master.c:345:19: error: Bad alignment nxstyle-master.c:346:21: error: Bad left brace alignment nxstyle-master.c:347:21: error: Bad right brace alignment nxstyle-master.c:349:19: error: Bad alignment nxstyle-master.c:351:21: error: Bad left brace alignment nxstyle-master.c:353:21: error: Bad right brace alignment nxstyle-master.c:354:17: error: Bad right brace alignment nxstyle-master.c:355:13: error: Bad right brace alignment nxstyle-master.c:406:1: error: Missing blank line after comment nxstyle-master.c:480:10: error: C++ style comment nxstyle-master.c:540:1: error: Missing blank line after comment nxstyle-master.c:609:0: error: C++ style comment nxstyle-master.c:609:0: error: No indentation line nxstyle-master.c:611:0: error: C++ style comment nxstyle-master.c:611:0: error: No indentation line nxstyle-master.c:617:0: error: C++ style comment nxstyle-master.c:617:0: error: No indentation line nxstyle-master.c:891:100: error: Long line found nxstyle-master.c:1189:1: error: Too many blank lines nxstyle-master.c:1211:56: error: Missing space before closing C comment nxstyle-master.c:1330:1: error: Missing blank line before comment found nxstyle-master.c:1356:1: error: Missing blank line before comment found nxstyle-master.c:1405:1: error: Missing blank line before comment found nxstyle-master.c:1446:1: error: Missing blank line before comment found nxstyle-master.c:1474:105: error: Long line found nxstyle-master.c:1501:1: error: Missing blank line before comment found nxstyle-master.c:1516:1: error: Missing blank line before comment found nxstyle-master.c:1544:1: error: Missing blank line before comment found nxstyle-master.c:1572:1: error: Missing blank line before comment found nxstyle-master.c:1592:1: error: Missing blank line before comment found nxstyle-master.c:1607:1: error: Missing blank line before comment found nxstyle-master.c:1626:1: error: Missing blank line before comment found nxstyle-master.c:1744:38: error: Operator/assignment must be preceded with whitespace ``` ## Test case 2 blank.c `nxstyle -m 90 blank.c` 45 lines of /n ``` ... ``` ` ./nxstyle -m 80 blank.c ` ``` blank.c:1:1: error: File begins with a blank line blank.c:2:1: error: Too many blank lines blank.c:3:1: error: Too many blank lines blank.c:4:1: error: Too many blank lines blank.c:5:1: error: Too many blank lines blank.c:6:1: error: Too many blank lines blank.c:7:1: error: Too many blank lines blank.c:8:1: error: Too many blank lines blank.c:9:1: error: Too many blank lines blank.c:10:1: error: Too many blank lines blank.c:11:1: error: Too many blank lines blank.c:12:1: error: Too many blank lines blank.c:13:1: error: Too many blank lines blank.c:14:1: error: Too many blank lines blank.c:15:1: error: Too many blank lines blank.c:16:1: error: Too many blank lines blank.c:17:1: error: Too many blank lines blank.c:18:1: error: Too many blank lines blank.c:19:1: error: Too many blank lines blank.c:20:1: error: Too many blank lines blank.c:21:1: error: Too many blank lines blank.c:22:1: error: Too many blank lines blank.c:23:1: error: Too many blank lines blank.c:24:1: error: Too many blank lines blank.c:25:1: error: Too many blank lines blank.c:26:1: error: Too many blank lines blank.c:27:1: error: Too many blank lines blank.c:28:1: error: Too many blank lines blank.c:29:1: error: Too many blank lines blank.c:30:1: error: Too many blank lines blank.c:31:1: error: Too many blank lines blank.c:32:1: error: Too many blank lines blank.c:33:1: error: Too many blank lines blank.c:34:1: error: Too many blank lines blank.c:35:1: error: Too many blank lines blank.c:36:1: error: Too many blank lines blank.c:37:1: error: Too many blank lines blank.c:38:1: error: Too many blank lines blank.c:39:1: error: Too many blank lines blank.c:40:1: error: Too many blank lines blank.c:41:1: error: Too many blank lines blank.c:42:1: error: Too many blank lines blank.c:43:1: error: Too many blank lines blank.c:44:1: error: Too many blank lines blank.c:45:1: error: Too many blank lines blank.c:45:1: fatal: "Private/Public Functions" not found! File was not be checked ``` ## Test case 3 ``` ./nxstyle -m 99 nxstyle.c` ``` ## Test case 4 ``` ./nxstyle -g -m 99 nxstyle.c nxstyle.c: PASSED nxstyle check ``` ## Test case 5 ``` ./nxstyle -g -m 99 nxstyle.c; echo $? nxstyle.c: PASSED nxstyle check 0 ``` ## Test case 6 ``` ./nxstyle -g -m 99 nxstyle-master.c; echo $? nxstyle-master.c: FAILED nxstyle check 1 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
