wingunder opened a new pull request #14: Fixed includes in arch/arm/src/stm32l4/hardware/. URL: https://github.com/apache/incubator-nuttx/pull/14 Several header files in arch/arm/src/stm32l4/hardware/ had the following line included: #include "chip.h" The problem with this was that the chip.h file is missing in this directory (in arch/arm/src/stm32l4/hardware/). The intended chip.h file to include was probably in arch/arm/src/stm32l4/chip.h. If any of the headers in arch/arm/src/stm32l4/hardware/ got included from a directory that did not contain a chip.h file, the compilation failed. After looking deeper into this I realized that the following files were also including files with the wrong paths: - arch/arm/src/stm32l4/hardware/stm32l4_syscfg.h - arch/arm/src/stm32l4/hardware/stm32l4_pinmap.h Finally, it seems as if a lot of headers, but not all, included: #include <nuttx/config.h> In this case, the include is only useful if a CONFIG_* define is being referenced. These includes were removed from files that had no CONFIG_* references and added to files that had CONFIG_* references, but was missing the include. The final change to be mentioned, was the moving of the GPIO defines from arch/arm/src/stm32l4/stm32l4_gpio.h to arch/arm/src/stm32l4/hardware/stm32l4_gpio.h. This was done to supply arch/arm/src/stm32l4/hardware/stm32l4*_pinmap.h with a local include for their GPIO references. This patch changes no functionality. It simply cleans up includes and allows inclusion of the headers in arch/arm/src/stm32l4/hardware/ from anywhere, without causing compiler errors.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
