patacongo commented on a change in pull request #19: Unify the c++ standard
library name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19#discussion_r362237598
##########
File path: tools/LibTargets.mk
##########
@@ -188,10 +188,10 @@ $(ARCH_SRC)$(DELIM)libuarch$(LIBEXT): context
staging$(DELIM)libuarch$(LIBEXT): $(ARCH_SRC)$(DELIM)libuarch$(LIBEXT)
$(Q) $(call INSTALL_LIB,$<,$@)
-libs$(DELIM)libxx$(DELIM)$(LIBXX)$(LIBEXT): context
- $(Q) $(MAKE) -C libs$(DELIM)libxx TOPDIR="$(TOPDIR)" $(LIBXX)$(LIBEXT)
KERNEL=n
+libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT): context
+ $(Q) $(MAKE) -C libs$(DELIM)libxx TOPDIR="$(TOPDIR)" libxx$(LIBEXT)
KERNEL=n
-staging$(DELIM)$(LIBXX)$(LIBEXT): libs$(DELIM)libxx$(DELIM)$(LIBXX)$(LIBEXT)
+staging$(DELIM)libxx$(LIBEXT): libs$(DELIM)libxx$(DELIM)libxx$(LIBEXT)
$(Q) $(call INSTALL_LIB,$<,$@)
Review comment:
Are you sure this is not correct? If you are using uClibc++, it installs
one location. if you are using libcxx, it installs at a different location.
Have you tried this with both C++ libraries to assure that it does not break
the build. I don't think we can merge this if we do not have that confidence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
