masayuki2009 opened a new pull request #21: net: tcp: Fix compile error in tcp.h URL: https://github.com/apache/incubator-nuttx/pull/21 During build testing for spresense with the latest master, I encountered the following compile error. ``` tcp/tcp_netpoll.c: In function 'tcp_pollsetup': ./tcp/tcp.h:1191:42: error: expected ')' before ';' token # define tcp_backlogavailable(c) (false); ^ tcp/tcp_netpoll.c:308:40: note: in expansion of macro 'tcp_backlogavailable' if (!IOB_QEMPTY(&conn->readahead) || tcp_backlogavailable(conn)) ^~~~~~~~~~~~~~~~~~~~ Makefile:102: recipe for target 'tcp_netpoll.o' failed ``` Actually, the line 1191 in tcp/tcp.h was added in 2014-07-06 but not used so far. And the line 308 in tcp/tcp_netpoll.c was not called on my environment before merging the following commit ``` commit 90c52e6f8f7efce97ac718c0f98addc13ec880d2 Author: Xiang Xiao <xiaoxi...@xiaomi.com> Date: Tue Dec 31 09:26:14 2019 -0600 ```` The fix in this PR is very trivial and I think @xiaoxiang781216 enabled CONFIG_NET_TCPBACKLOG on his environments because he did not encounter the error.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
